Added entrypoint to imagespec and default builder #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pryce-turner <pryce.turner@gmail.com>
pryce-turner
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Signed-off-by: pryce-turner <pryce.turner@gmail.com>
thomasjpfan
reviewed
Jul 3, 2024
Signed-off-by: pryce-turner <pryce.turner@gmail.com>
…optional str to avoid entrypoint reset behavior Signed-off-by: pryce-turner <pryce.turner@gmail.com>
pingsutw
approved these changes
Jul 3, 2024
|
I'll update the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2553 +/- ##
===========================================
+ Coverage 53.88% 77.28% +23.40%
===========================================
Files 183 217 +34
Lines 18716 19873 +1157
Branches 3694 3695 +1
===========================================
+ Hits 10085 15359 +5274
+ Misses 8143 3880 -4263
- Partials 488 634 +146 ☔ View full report in Codecov by Sentry. |
pryce-turner
deleted the
pryce/dx-850-add-entrypoint-handling-to-imagespec
branch
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Added entrypoint to imagespec and default builder Signed-off-by: pryce-turner <pryce.turner@gmail.com> * Added docstring Signed-off-by: pryce-turner <pryce.turner@gmail.com> * Revert reqs.txt Signed-off-by: pryce-turner <pryce.turner@gmail.com> * Fixed falsey behavior of empty list, moved ENTRYPOINT directive into optional str to avoid entrypoint reset behavior Signed-off-by: pryce-turner <pryce.turner@gmail.com> --------- Signed-off-by: pryce-turner <pryce.turner@gmail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Jul 29, 2024
* Added entrypoint to imagespec and default builder Signed-off-by: pryce-turner <pryce.turner@gmail.com> * Added docstring Signed-off-by: pryce-turner <pryce.turner@gmail.com> * Revert reqs.txt Signed-off-by: pryce-turner <pryce.turner@gmail.com> * Fixed falsey behavior of empty list, moved ENTRYPOINT directive into optional str to avoid entrypoint reset behavior Signed-off-by: pryce-turner <pryce.turner@gmail.com> --------- Signed-off-by: pryce-turner <pryce.turner@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Base image entrypoints will sometimes conflict with
pyflyte-executethis option allows the user to either nullify or replace the entrypoint of the base image.What changes were proposed in this pull request?
Adds
entrypointattr to ImageSpecHow was this patch tested?
unit tests
Check all the applicable boxes