-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for flytekit version to be specified in default image builder #2563
Allow for flytekit version to be specified in default image builder #2563
Conversation
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2563 +/- ##
===========================================
- Coverage 80.31% 50.88% -29.44%
===========================================
Files 186 183 -3
Lines 18880 18736 -144
Branches 3915 3697 -218
===========================================
- Hits 15164 9534 -5630
- Misses 3059 8710 +5651
+ Partials 657 492 -165 ☔ View full report in Codecov by Sentry. |
…2563) * Allow for flytekit version to be specified Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * REV Revert Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * REV Revert Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * Adds more comments Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> --------- Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
…lyteorg#2563) * Allow for flytekit version to be specified Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * REV Revert Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * REV Revert Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * Adds more comments Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> --------- Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Why are the changes needed?
With
1.13.0
, the default image builder does not allowflytekit
to be specified to a specific version. For example, the following will fail:with:
What changes were proposed in this pull request?
With this PR, we check for
flytekit
first. If it is not detected inrequirements
, then we injectflytekit
into the requirements with the version used during registration.How was this patch tested?
Unit test was added to this PR.