Fix CSS with Flyte decks #2565
Merged
Fix CSS with Flyte decks #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla and
Future-Outlier
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2565 +/- ##
===========================================
- Coverage 80.31% 50.89% -29.43%
===========================================
Files 186 270 +84
Lines 18880 22945 +4065
Branches 3915 3695 -220
===========================================
- Hits 15164 11678 -3486
- Misses 3059 11158 +8099
+ Partials 657 109 -548 ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Jul 5, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Jan Fiedler <jan@union.ai>
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Jul 29, 2024
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The Flyte Deck's width extends past the width of the window:
What changes were proposed in this pull request?
With this PR, the bounds are properly set:
How was this patch tested?
I build an image with the new changes and ran a simple workflow.