Fixes boundary conditions for literal convertor #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
kumare3
requested review from
wild-endeavor,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com>
pingsutw
approved these changes
Jul 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2596 +/- ##
==========================================
+ Coverage 49.85% 50.35% +0.49%
==========================================
Files 196 199 +3
Lines 20128 20436 +308
Branches 2929 2604 -325
==========================================
+ Hits 10035 10290 +255
- Misses 9562 9618 +56
+ Partials 531 528 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
approved these changes
Oct 10, 2024
otarabai
pushed a commit
to otarabai/flytekit
that referenced
this pull request
Oct 15, 2024
* Fixes boundary conditions for literal convertor Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> * Better fix Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> --------- Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Ketan Umare <kumare3@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
kumare3
added a commit
that referenced
this pull request
Nov 8, 2024
* Fixes boundary conditions for literal convertor Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> * Better fix Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> --------- Signed-off-by: Ketan Umare <kumare3@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Ketan Umare <kumare3@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Cases in which no inputs are specified this fails if the converter is invoked. This adds boundary conditions. this only gets invoked if someone invokes it directly or in the agent case.
What changes were proposed in this pull request?
Check if no inputs are specified return immediately
How was this patch tested?
locally