Implement sidecar tasks and task resource specification #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
requested review from
kumare3,
matthewphsmith and
wild-endeavor
as code owners
kumare3
reviewed
Nov 24, 2020
| from flytekit.common.exceptions import user as _user_exceptions | ||
| from flytekit.models import task as _task_model | ||
| from flytekit.models import task as _task_models | ||
| from flytekit.plugins import k8s as _lazy_k8s |
There was a problem hiding this comment.
I do not think you need to do this. But, I guess lets keep it. I need to move all the _lazy_k8s logic to the plugins
flytekit/annotated/resources.py
Outdated
| limits: Resource = None | ||
|
|
||
|
|
||
| def _get_resources(**kwargs): |
There was a problem hiding this comment.
also, does it work if you put all the kwargs in the function declaration? doesn't really matter, but maybe can play around with it.
There was a problem hiding this comment.
i will gladly not _
| @@ -88,6 +89,8 @@ def __init__( | |||
| self._task_function = task_function | |||
| self._task_config = task_config | |||
| self._container_image = container_image | |||
| # TODO(katrogan): Implement resource overrides | |||
| self._resources = _get_resources(**kwargs) | |||
There was a problem hiding this comment.
if you're going to use self._resources then add a property so that self.resources returns the object?
| storage_limit=self._resources.limits.storage, | ||
| cpu_limit=self._resources.limits.cpu, | ||
| gpu_limit=self._resources.limits.gpu, | ||
| memory_limit=self._resources.limits.mem, | ||
| ) |
There was a problem hiding this comment.
should add **kwargs as the last item.
There was a problem hiding this comment.
talked offline, added to get_resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the resources to a separate location to avoid a circular dependency with task and python_function_task, let me know if it belongs elsewhere.
Also the foo().with_overrides(cpu="1") syntax is not implemented by these changes