Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tuple handling in condition branches #279

Merged
merged 7 commits into from
Dec 15, 2020
Merged

Fix tuple handling in condition branches #279

merged 7 commits into from
Dec 15, 2020

Conversation

EngHabu
Copy link
Collaborator

@EngHabu EngHabu commented Dec 15, 2020 •
edited
Loading

TL;DR

condition handling of tuples in tasks was broken because it assumed always a single Promise will be returned.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

@EngHabu EngHabu marked this pull request as ready for review December 15, 2020 23:26
@EngHabu EngHabu merged commit 0cebfd0 into flyteorg:annotations Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wild-endeavor wild-endeavor wild-endeavor approved these changes

@kumare3 kumare3 kumare3 approved these changes

@matthewphsmith matthewphsmith Awaiting requested review from matthewphsmith matthewphsmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EngHabu @wild-endeavor @kumare3