ensure a space is added if both args are set in ImageSpec #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Blake Jackson <blake@BB8.local>
blaketastic2
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: Blake Jackson <blake@BB8.local>
blaketastic2
force-pushed
the
support-multiple-values
branch
from
4815139 to
40bea53
Compare
thomasjpfan
changed the title
thomasjpfan
approved these changes
Oct 11, 2024
|
Congrats on merging your first pull request! 🎉 |
kumare3
pushed a commit
that referenced
this pull request
Nov 8, 2024
* ensure a space is added if both args are set Signed-off-by: Blake Jackson <blake@BB8.local> * removed space normalizing step Signed-off-by: Blake Jackson <blake@BB8.local> --------- Signed-off-by: Blake Jackson <blake@BB8.local> Co-authored-by: Blake Jackson <blake@BB8.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
If both
--index-urland--extra-index-urlare set, a space is missing between the 2, resulting in an error.What changes were proposed in this pull request?
How was this patch tested?
Added unit test and visualized the docker command output.
Setup process
Screenshots
Check all the applicable boxes