Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move around void promise #282

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Move around void promise #282

merged 1 commit into from
Dec 22, 2020

Conversation

wild-endeavor
Copy link
Contributor

Maybe?

@wild-endeavor wild-endeavor changed the title [wip] move around void promise? Move around void promise? Dec 21, 2020
kumare3
kumare3 reviewed Dec 21, 2020
View reviewed changes
flytekit/annotated/base_task.py
@@ -131,6 +129,10 @@ def _local_execute(self, ctx: FlyteContext, **kwargs) -> Union[Tuple[Promise], P
# Length check, clean up exception
raise AssertionError(f"Length difference {len(output_names)} {len(outputs_literals)}")

# Tasks that don't return anything still return a VoidPromise
if len(output_names) == 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably makes more sense

@kumare3 kumare3 self-requested a review December 21, 2020 20:53
@wild-endeavor wild-endeavor merged commit 99b638f into annotations Dec 22, 2020
@wild-endeavor wild-endeavor changed the title Move around void promise? Move around void promise Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumare3 kumare3 kumare3 approved these changes

@matthewphsmith matthewphsmith Awaiting requested review from matthewphsmith matthewphsmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wild-endeavor @kumare3