Backport 2845 v1.13 #2851
Merged
Backport 2845 v1.13 #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* temp Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * delete test Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * allow strings Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * remove enum transformer change and tests Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * reset a test Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * lint Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * use .value for enums to handle dynamic case Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * use prior logic for 3.9 Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add 3.9 testing Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * should always be a union type Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> --------- Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
eapolinario
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport https://github.com/flyteorg/flytekit/pull/2845/files