Restrict Eager Task for Interactive Mode #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Mecoli1219
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
pingsutw
approved these changes
Oct 27, 2024
Future-Outlier
approved these changes
Oct 28, 2024
kumare3
pushed a commit
that referenced
this pull request
Nov 8, 2024
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5907
Why are the changes needed?
Eager task is not supported in interactive mode now, so we should throw an error when executing workflow that contains eager task.
What changes were proposed in this pull request?
Throw an error if an entity is a eager task during interactive mode
How was this patch tested?
Unit test & test run
Setup process
Screenshots
Check all the applicable boxes
Related PRs
#2849
Docs link