Sidecar tasks are now Pod tasks #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
requested review from
kumare3,
matthewphsmith and
wild-endeavor
as code owners
kumare3
reviewed
Dec 24, 2020
flytekit/taskplugins/pod/__init__.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| from .task import Pod | |||
|
|
|||
| __all__ = [Pod] | |||
There was a problem hiding this comment.
so the `all`` should be a list of string names of the modules you want to expose.
I think you can just skip it, refer to my new PR
|
thanks @kumare3 also posted in flytekit slack and will wait until next week to see if anyone has strong opinions |
jeevb
approved these changes
Dec 25, 2020
|
@jeevb thanks for reviewing! we haven't yet ported over dynamic sidecar tasks (dynamic pod tasks?) to the new flytekit but that is in the pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.