Use the same source of time in flaky test #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
pingsutw
approved these changes
Dec 17, 2024
shuyingliang
pushed a commit
to shuyingliang/flytekit
that referenced
this pull request
Dec 20, 2024
* Use the same source of time in flaky test Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use proto Timestamp to get current time Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
test_get_container_error_timestamphas been failing semi-consistently only on Windows. We all hate flaky tests.What changes were proposed in this pull request?
The test relies on the function
get_container_error_timestampwhich returns a protobuf Timestamp object, which usestime.timeto collect the current time. However, the granularity oftime.timeanddatetime.noware different (the latter being more precise as per https://docs.python.org/3/library/datetime.html#datetime.datetime.now).How was this patch tested?
I don't have a Windows machine, but tests run fine locally. Will kick off a few runs in CI just to confirm.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link