Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set asyncio_default_fixture_loop_scope #3034

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

machichima
Copy link
Contributor

Tracking issue

Why are the changes needed?

As suggested in the pytest warning below:

PytestDepreca
tionWarning: The configuration option "asyncio_default_fixture_loop_scope" is unset.                                                                                      
The event loop scope for asynchronous fixtures will default to the fixture caching scope. Future versions of pytest-asyncio will default the loop scope for asynchronous f
ixtures to function scope. Set the default fixture loop scope explicitly in order to avoid unexpected behavior in the future. Valid fixture loop scopes are: "function", "
class", "module", "package", "session"

Set the "asyncio_default_fixture_loop_scope" explicitly to "function", which is the default value (as described here: https://pytest-asyncio.readthedocs.io/en/latest/reference/configuration.html#asyncio-default-fixture-loop-scope)

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

set this explicitly to prevent PytestDeprecationWarning

Signed-off-by: machichima <nary12321@gmail.com>
@flyte-bot
Copy link
Contributor

flyte-bot commented Jan 4, 2025

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - We encountered technical difficulties while attempting to generate code feedback. Please try again or contact support@bito.ai.

@thomasjpfan thomasjpfan merged commit 4e93e36 into flyteorg:master Jan 8, 2025
102 checks passed
Copy link

welcome bot commented Jan 8, 2025

Congrats on merging your first pull request! 🎉

shuyingliang pushed a commit to shuyingliang/flytekit that referenced this pull request Jan 11, 2025
set this explicitly to prevent PytestDeprecationWarning

Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: Shuying Liang <shuying.liang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants