update ollama plugin to reflect API changes #3065
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Code Review Agent Run Status
|
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Code Review Agent Run Status
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3065 +/- ##
==========================================
- Coverage 79.53% 76.94% -2.59%
==========================================
Files 202 270 +68
Lines 21370 23897 +2527
Branches 2746 2746
==========================================
+ Hits 16997 18388 +1391
- Misses 3603 4737 +1134
- Partials 770 772 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
cosmicBboy
reviewed
Jan 16, 2025
plugins/flytekit-inference/flytekitplugins/inference/ollama/serve.py
Outdated
Show resolved
Hide resolved
Code Review Agent Run Status
|
cosmicBboy
reviewed
Jan 16, 2025
Comment on lines
+58
to
+59
| Python 3.12 or higher is required due to support for backslashes in f-strings: | ||
| https://realpython.com/python312-f-strings/#backslashes-now-allowed-in-f-strings |
There was a problem hiding this comment.
I think using the NEWLINE and NEWLINE_ESCAPED global vars should address this
Code Review Agent Run Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
The Ollama Python API and backend were updated, necessitating unpinning the version and making adjustments to the plugin to ensure compatibility.
What changes were proposed in this pull request?
Replaced the modelfile field with individual fields that correspond directly to the attributes previously defined in the modelfile.
How was this patch tested?
There's an end-to-end example available, and I've tested it—it works as expected.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link