Annotations - workflow metadata #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wild-endeavor
commented
Dec 31, 2020
•
wild-endeavor
commented
- Add a WorkflowMetadata dataclass
- Add a WorkflowMetadataDefaults dataclass
- Hook up data classes to constuctors and expose those settings in the workflow decorator
- Remove unnecessary Workflow input to construct_input_promises
- Add a docstring to the workflow decorator.
wild-endeavor
requested review from
kumare3 and
matthewphsmith
as code owners
kumare3
reviewed
Jan 4, 2021
| def workflow(_workflow_function=None, *args, reference: Optional[WorkflowReference] = None, **kwargs): | ||
| def workflow( | ||
| _workflow_function=None, | ||
| reference: Optional[WorkflowReference] = None, |
There was a problem hiding this comment.
the workflow has both - reference and metadata. I guess we will keep it like task. That was one though I had, should we just expose the WorkflowMetadata TaskMetadata objects to the user?
kumare3
reviewed
Jan 4, 2021
|
|
||
|
|
||
| @dataclass | ||
| class WorkflowMetadataDefaults(object): |
There was a problem hiding this comment.
can we call this something else like WorkflowDefaults much better than WorkflowMetadataDefaults
And should this be part of WorkflowMetadata?
There was a problem hiding this comment.
I'm okay with this as it stands but up to you. They are two separate objects in the IDL so I just kept that pattern, it makes the to_flyte_model function easier to reason about. Also, these aren't exposed, only the settings themselves are in the decorator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.