Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flytesnacks links #474

Merged
merged 2 commits into from
May 7, 2021
Merged

Update flytesnacks links #474

merged 2 commits into from
May 7, 2021

Conversation

cosmicBboy
Copy link
Contributor

TL;DR

This PR fixes intersphinx references for pages that need to be update due to flyteorg/flytesnacks#200

Type

  • Bug Fix
  • Feature
  • Plugin
  • Docs

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

cosmicBboy added 2 commits May 7, 2021 13:53
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #474 (493d502) into master (f31048b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files         362      362           
  Lines       27010    27010           
  Branches     2227     2227           
=======================================
  Hits        22840    22840           
  Misses       3568     3568           
  Partials      602      602           
Impacted Files Coverage Δ
flytekit/core/dynamic_workflow_task.py 100.00% <ø> (ø)
flytekit/core/resources.py 100.00% <ø> (ø)
flytekit/core/schedule.py 89.28% <ø> (ø)
flytekit/core/workflow.py 87.64% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31048b...493d502. Read the comment docs.

@cosmicBboy cosmicBboy merged commit d01db17 into master May 7, 2021
max-hoffman pushed a commit to dolthub/flytekit that referenced this pull request May 11, 2021
* update flytesnacks links to use intersphinx ref roles

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* update

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
@cosmicBboy cosmicBboy deleted the update-flytesnacks-links branch May 24, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants