Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python pickle type in flytekit/flyte #667

Merged
merged 32 commits into from
Oct 27, 2021
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed test
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw committed Oct 26, 2021

Verified

This commit was signed with the committer’s verified signature.
Acconut Marius Kleidl
commit e22cc93f3e924a7ec399e573db1e195fab46537d
6 changes: 1 addition & 5 deletions tests/flytekit/unit/core/test_type_hints.py
Original file line number Diff line number Diff line change
@@ -1425,9 +1425,5 @@ def foo3(a: typing.Dict) -> typing.Dict:
with pytest.raises(TypeError, match="Failed to convert return value for var o0 for function test_type_hints.foo2"):
foo2(a=10, b="hello")

with pytest.raises(
TypeError,
match='Not a collection type simple: STRUCT\nmetadata {\n fields {\n key: "python_class_name"\n'
" value {\n string_value: \"VT\"\n }\n }\n}\n but got a list \\[{'hello': 2}\\]",
):
with pytest.raises(TypeError, match="Not a collection type simple: STRUCT\n but got a list \\[{'hello': 2}\\]"):
foo3(a=[{"hello": 2}])