Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Log Links CloudWatch FluentD #292

Closed

Conversation

Smartmind12
Copy link

Signed-off-by: Utsav Paul 91927689+Smartmind12@users.noreply.github.com

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Change the default template defined so that Log Links work with CloudWatch FluentD Out Of the Box

Tracking Issue

fixes flyteorg/flyte#2635

Signed-off-by: Utsav Paul <91927689+Smartmind12@users.noreply.github.com>
@welcome
Copy link

welcome bot commented Oct 22, 2022

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@Smartmind12 Smartmind12 changed the title Update logging_utils.go Log Links CloudWatch FluentD Oct 22, 2022
@samhita-alla
Copy link
Contributor

@Smartmind12, thanks for creating the PR. But since the issue is assigned to a different person who created a PR already, I'm going to close this.

@Smartmind12
Copy link
Author

Smartmind12 commented Oct 24, 2022

@samhita-alla Was it not first PR submitted will be checked first kind of rule??

@Smartmind12
Copy link
Author

& also the other PR has the wrong command being commited so kindly reopen this PR!

@samhita-alla
Copy link
Contributor

@Smartmind12, it is. When there are two PRs, I'll have to merge the one that has been fixed by the assignee. Also, what's wrong in the other PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Log Links should work with CloudWatch FluentD Out Of the Box
2 participants