This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Adding support for environment variables set on execution #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <daniel@union.ai>
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 62.77% 63.98% +1.21%
==========================================
Files 148 146 -2
Lines 12434 9921 -2513
==========================================
- Hits 7805 6348 -1457
+ Misses 4034 2989 -1045
+ Partials 595 584 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
hamersaw
changed the title
pingsutw
approved these changes
May 3, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* added environment variables to TaskExecutionMetadata Signed-off-by: Daniel Rammer <daniel@union.ai> * added support for environment variables Signed-off-by: Daniel Rammer <daniel@union.ai> * implemented unit tests and fixed linter Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds support for passing environment variables through the
TaskExecutionMetadata(which maybe set onExecutionContextwithin flytepropeller) to support setting environment variables at workflow runtime.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#2447
Follow-up issue
NA