This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add dask plugin #508
Merged
Add dask plugin #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstadlbauer
requested review from
kumare3,
EngHabu and
hamersaw
as code owners
Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net>
Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net>
bstadlbauer
force-pushed
the
add-dask-plugin
branch
from
72f18f0 to
fc99a5d
Compare
6 tasks
Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net>
Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net>
Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net>
bstadlbauer
force-pushed
the
add-dask-plugin
branch
2 times, most recently
from
c5ecd4f to
3b0cd29
Compare
Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net>
bstadlbauer
force-pushed
the
add-dask-plugin
branch
from
3b0cd29 to
ee7a12a
Compare
hamersaw
approved these changes
Jan 7, 2023
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Add dask plugin Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Use `ToK8sResourceRequirements` from flyteplugins Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Run go mod tidy after merge Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update flyteplugins to 1.0.28 Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Fix linting error Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds support for the
daskbackend pluginType
Are all requirements met?
Complete description
This mainly adds the dependency on
"github.com/flyteorg/flyteplugins/go/tasks/plugins/k8s/dask"As part of this (to avoid code duplication),
TestToK8sResourceRequirementshas been moved intoflytepluginsin flyteorg/flyteplugins@6be8764TODO before this can be merged.
Tracking Issue
flyteorg/flyte#427
Follow-up issue
NA