-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr 1741 #1742
base: master
Are you sure you want to change the base?
Pr 1741 #1742
Conversation
Hi! I have used enable_deck=True as told, actually first I used disable_deck=False, and created pull request 1741 but then since it was deprecated, i edited it to enable_deck=True and made this change |
…te deck Signed-off-by: RaghavMangla <raghavmangla04@gmail.com>
done
…On Tue, Oct 8, 2024 at 2:56 PM Samhita Alla ***@***.***> wrote:
can you fix the DCO?
https://github.com/flyteorg/flytesnacks/pull/1742/checks?check_run_id=31121459053
—
Reply to this email directly, view it on GitHub
<#1742 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXGSZMKIELT5NT3PVEPYDPDZ2OQNDAVCNFSM6AAAAABPNPFL32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGMZTCNRXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
btw can u also review this pr, @ <https://github.com/samhita-alla>
flyteorg/flytekit#2791 <flyteorg/flytekit#2791>, i
think its relevant to this issue
On Tue, Oct 8, 2024 at 3:53 PM Raghav Mangla ***@***.***>
wrote:
… done
On Tue, Oct 8, 2024 at 2:56 PM Samhita Alla ***@***.***>
wrote:
> can you fix the DCO?
> https://github.com/flyteorg/flytesnacks/pull/1742/checks?check_run_id=31121459053
>
> —
> Reply to this email directly, view it on GitHub
> <#1742 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AXGSZMKIELT5NT3PVEPYDPDZ2OQNDAVCNFSM6AAAAABPNPFL32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGMZTCNRXGM>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Just noticed that the PR run failed for
#1742/, can u pls share abt how
to fix this issue
On Tue, Oct 8, 2024 at 3:56 PM Raghav Mangla ***@***.***>
wrote:
… btw can u also review this pr, @ <https://github.com/samhita-alla>
flyteorg/flytekit#2791 <flyteorg/flytekit#2791>,
i think its relevant to this issue
On Tue, Oct 8, 2024 at 3:53 PM Raghav Mangla ***@***.***>
wrote:
> done
>
> On Tue, Oct 8, 2024 at 2:56 PM Samhita Alla ***@***.***>
> wrote:
>
>> can you fix the DCO?
>> https://github.com/flyteorg/flytesnacks/pull/1742/checks?check_run_id=31121459053
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#1742 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AXGSZMKIELT5NT3PVEPYDPDZ2OQNDAVCNFSM6AAAAABPNPFL32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGMZTCNRXGM>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
|
@RaghavMangla I think that might have been a timeout error, so I re-ran the failed test. |
@samhita-alla @neverett Hi! can u pls review the PR, all checks have passed |
fixed deprecated disable_deck, enable_deck=True has been used
fixes flyteorg/flyte#4463