Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add pod start and finish time in RFC3339 time format to logging link templating variables #998

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

fg91
Copy link
Member

@fg91 fg91 commented Jun 13, 2023

Documentation for flyteorg/flyteplugins#360

Fabio Grätz and others added 2 commits June 14, 2023 10:17
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
Signed-off-by: Fabio M. Graetz, Ph.D. <fabiograetz@googlemail.com>
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
@fg91 fg91 force-pushed the fg91/feat/rfc339-start-time-log-link-param branch from 1b28e7f to 4c9f2e2 Compare June 14, 2023 08:17
@fg91 fg91 requested a review from hamersaw June 14, 2023 08:18
hamersaw
hamersaw previously approved these changes Jun 15, 2023
Signed-off-by: Fabio Grätz <fabiogratz@googlemail.com>
@fg91 fg91 force-pushed the fg91/feat/rfc339-start-time-log-link-param branch from 0c715ce to e33424d Compare June 15, 2023 14:52
@fg91 fg91 requested a review from hamersaw June 15, 2023 14:52
@fg91
Copy link
Member Author

fg91 commented Jun 15, 2023

@hamersaw documentation build failed because wrong indentation

@cosmicBboy cosmicBboy merged commit a4930ce into master Jun 15, 2023
@cosmicBboy cosmicBboy deleted the fg91/feat/rfc339-start-time-log-link-param branch June 15, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants