Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/2028: implement responsive navbar header #10

Merged
merged 4 commits into from
Jan 8, 2022
Merged

Conversation

cosmicBboy
Copy link
Collaborator

@cosmicBboy cosmicBboy commented Jan 7, 2022

This PR implements a responsive navbar header to create a more cohesive navigation experience for Flyte users.

This should be the first PR merged before merging the changes in all of the other relevant repos:

- implement responsive top-level navigation for main docs sections
- hack sidebar nav so that only relevant information shows up

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Copy link

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After carefully rendering the changes in my head, I think it looks beautiful!

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@cosmicBboy cosmicBboy changed the title docs/2028: implement response navbar header docs/2028: implement responsive navbar header Jan 7, 2022
@cosmicBboy cosmicBboy merged commit 091fdff into main Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants