Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop app: sign macOS release #134

Closed
fmaclen opened this issue Aug 4, 2024 · 3 comments · Fixed by #146
Closed

Desktop app: sign macOS release #134

fmaclen opened this issue Aug 4, 2024 · 3 comments · Fixed by #146
Labels
priority released tech-debt Stuff that works, but could be optimized

Comments

@fmaclen
Copy link
Owner

fmaclen commented Aug 4, 2024 •
edited
Loading

https://www.electron.build/code-signing
@fmaclen fmaclen added priority tech-debt Stuff that works, but could be optimized labels Aug 4, 2024
@fmaclen
Copy link
Owner Author

fmaclen commented Aug 6, 2024

Once the code is signed we should try enabling an arm64 release for macOS.
We would do this by adding macos-latest to the release.yml matrix.

Currently, if we add macos-latest to the matrix the release get's built but when we try to execute macOS says the app is damaged. My understanding is that Apple expects apps for Apple Silicon to be signed.

@fmaclen fmaclen changed the title Desktop app: sign macOS and Windows releases Desktop app: sign macOS Aug 7, 2024
@fmaclen fmaclen changed the title Desktop app: sign macOS Desktop app: sign macOS release Aug 7, 2024
fmaclen added a commit that referenced this issue Aug 7, 2024
@fmaclen
fix: sign macOS releases & add new release for arm64
4f4c6e7 
Closes #134
This was referenced Aug 7, 2024
Merged
Open
@fmaclen
Copy link
Owner Author

fmaclen commented Aug 7, 2024

Decided to punt on code-signing the Windows releases (#147)

@fmaclen fmaclen closed this as completed in 96befb6 Aug 7, 2024
@fmaclen
Copy link
Owner Author

fmaclen commented Aug 7, 2024

🎉 This issue has been resolved in version 0.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority released tech-debt Stuff that works, but could be optimized
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sign macOS releases & add new release for arm64 fmaclen/hollama
1 participant
@fmaclen