-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for OpenAI #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had time to do a lot of deep analysis but directionally I think it's a great start 👍
Left you some comments related to how I think we should choose one strategy over the other.
Another minor thing is that we can probably drop the strategy
naming convention, at least on the file names.
Thanks for the feedback! I'm working on it 🫡 |
@fmaclen Just to be sure: should we get rid of all the 'connected' or 'disconnected' logic? For example, in the |
@GregoMac1 let's keep that functionality only in the Settings view, it's still useful to know if we are correctly connected to an Ollama server. |
Remaining tasks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't able to try the functionality, when visiting a Session I kept getting a Can't connect to Ollama server
error, even though my Ollama server was running.
Left you several comments but primarily I think we should limit the amount of calls we do to the API.
provided solution is based in [this reference](https://stackoverflow.com/questions/57392773/error-type-attribute-cannot-be-dynamic-if-input-uses-two-way-binding/75298645#75298645)
Deploying hollama with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some changes for updating the MOTD
and README
.
I also merged the latest set of changes from main
and now there are 3 test failures.
Everything else looks good AFAIK, let's get those test fixed and we'll get this out 🚀
@GregoMac1 I get these 2 tests failing:
This one I'm not entirely sure why it's failing,
This next test actually broke with the changes we made to Sessions: I suspect that when you were running the tests locally you didn't have an Ollama server running at the same time, if you do you'll see the error I'm getting in the flash alert. I think the issue is that we were mocking
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was certainly a tough one but I think we are good to go 👍
Let's get it out!
🎉 This PR is included in version 0.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.