Enable --incompatible_sandbox_hermetic_tmp by default

Fixes bazelbuild#3236 Fixes bazelbuild#19915
fmeum · Oct 25, 2023 · ddadf98 · ddadf98
1 parent 877f845
commit ddadf98
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/.bazelrc b/.bazelrc
@@ -58,9 +58,6 @@ build --incompatible_disallow_empty_glob
 # Manually enable cc toolchain resolution before it is flipped. https://github.com/bazelbuild/bazel/issues/7260
 build --incompatible_enable_cc_toolchain_resolution
 
-# Fix non-deterministic Java compilation failures (https://github.com/bazelbuild/bazel/issues/3236)
-build --incompatible_sandbox_hermetic_tmp
-
 # User-specific .bazelrc
 try-import %workspace%/user.bazelrc
 

diff --git a/src/main/java/com/google/devtools/build/lib/sandbox/SandboxOptions.java b/src/main/java/com/google/devtools/build/lib/sandbox/SandboxOptions.java
@@ -350,7 +350,7 @@ public ImmutableSet<Path> getInaccessiblePaths(FileSystem fs) {
 
  @Option(
  name = "incompatible_sandbox_hermetic_tmp",
- defaultValue = "false",
+ defaultValue = "true",
  documentationCategory = OptionDocumentationCategory.EXECUTION_STRATEGY,
  effectTags = {OptionEffectTag.EXECUTION},
  help =