Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update social-media-tools.md #2348

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Update social-media-tools.md #2348

merged 3 commits into from
Sep 9, 2024

Conversation

itsvijaysingh
Copy link
Contributor

add discord pfp viewer tool, lookup tool and collection website

add discord pfp viewer tool, lookup tool and collection website
@github-actions github-actions bot added the docs Content changes label Sep 8, 2024
@Setsuwaa
Copy link
Contributor

Setsuwaa commented Sep 8, 2024

Why did you add it twice? Also, there's two links for the same thing right above that.
pfpfinder.com isn't meant just for DLing pfps but other things too, so I think it should be added to /img-tools#icons-avatars or /social-media-tools#client-customization. (It does advertise itself as a discord pfp tool, but I don't see any reason to restrict images to one site when they can be used everywhere which is why I don't think it should be added to client-customization.)

Removed site from social-media-tools.md and added it to img-tools.md
Removed pfpfinder.com from social-media-tools.md and added it to img-tools.md
@itsvijaysingh
Copy link
Contributor Author

Why did you add it twice? Also, there's two links for the same thing right above that. pfpfinder.com isn't meant just for DLing pfps but other things too, so I think it should be added to /img-tools#icons-avatars or /social-media-tools#client-customization. (It does advertise itself as a discord pfp tool, but I don't see any reason to restrict images to one site when they can be used everywhere which is why I don't think it should be added to client-customization.)

Hi ,

I've made the following updates based on your feedback:

Removed Duplicates: The redundant entries for site, in social-media-tools.md have been removed.

Re-categorized Content: I’ve added the entry to the appropriate section in img-tools.md.

@Setsuwaa
Copy link
Contributor

Setsuwaa commented Sep 8, 2024

Looks good!

@nbats nbats merged commit 7c475b7 into fmhy:main Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Content changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants