Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Momentum Indicators - RSI, MACD ... #120

Conversation

pythonhacker
Copy link

@pythonhacker pythonhacker commented Jul 31, 2023

Implementation of RSI momentum indicator, ref -> #119

@pythonhacker pythonhacker changed the title ref issue - 119 - RSI indicator Momentum Indicators - RSI, MACD ... Aug 1, 2023
@fmilthaler
Copy link
Owner

Hey @pythonhacker , love your enthusiasm and you adding new features. Thank you very much.
Expect a review this weekend, as there is quite a bit to go through and do my research on those features myself :)
Anyway, could you please add some unit tests (I know that some of the current features are not well tested, but that will be addressed in the near future). Also, could I ask you to add this to the file example/Example-Analysis.py with some nice text etc to showcase these new features to FinQuant's users.

@fmilthaler
Copy link
Owner

FYI: You can ignore the failed pipeline "Formatting and Version Increment...". It's a new pipeline and just ran for the first time on a fork. Added a new issue #124 . Since it failed, the easiest way forward is probably to change the target branch to fmilthaler:feature/rsi-indicator. When everything looks good, we'll merge it into that branch, and then the pipeline will run just fine, updating the version and formatting automatically. Following that, we'll merge it into master.

@pythonhacker
Copy link
Author

FYI: You can ignore the failed pipeline "Formatting and Version Increment...". It's a new pipeline and just ran for the first time on a fork. Added a new issue #124 . Since it failed, the easiest way forward is probably to change the target branch to fmilthaler:feature/rsi-indicator. When everything looks good, we'll merge it into that branch, and then the pipeline will run just fine, updating the version and formatting automatically. Following that, we'll merge it into master.

Got it. Will look into unit-tests and documentation.

@fmilthaler fmilthaler changed the base branch from master to feature/rsi-indicator August 5, 2023 13:12
@fmilthaler
Copy link
Owner

I'll merge this not into master, but into feature/rsi-indicator so that I can make the necessary additions and play around with it before it gets merged into master. Thank you for this addition @pythonhacker. :)

@fmilthaler fmilthaler merged commit 6076d71 into fmilthaler:feature/rsi-indicator Aug 5, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants