Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format-impl-test fails to link using MacPorts Clang #1461

Closed
jwillikers opened this issue Dec 6, 2019 · 3 comments
Closed

format-impl-test fails to link using MacPorts Clang #1461

jwillikers opened this issue Dec 6, 2019 · 3 comments

Comments

@jwillikers
Copy link
Contributor

jwillikers commented Dec 6, 2019

On macOS, the format-impl-test fails to link when using the MacPorts Clang compiler. This is due to the "ifdef apple_build_version" check in the format-impl-test.cc file for value_extractor class. This only checks if the Clang compiler is Apple's Clang, but not whether Apple's libc++ is being linked. Simply replacing the macro with TARGET_OS_MAC corrects my issue, but I don't think this is very robust. I recommend using CMake's CheckCXXSourceRuns to reliably detect whether __int128_t and __uint128_t are available.

@vitaut
Copy link
Contributor

vitaut commented Dec 6, 2019

apple_build_version should just be replaced with FMT_USE_INT128.

@jwillikers
Copy link
Contributor Author

Well... isn't that convenient? :) The test runs successfully when I replace apple_build_version with FMT_USE_INT128.

@vitaut
Copy link
Contributor

vitaut commented Dec 9, 2019

Fixed in 73a16b8.

@vitaut vitaut closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants