Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument shadowing and Clang pedantic support #190

Closed
rpopescu opened this issue Aug 4, 2015 · 1 comment
Closed

Argument shadowing and Clang pedantic support #190

rpopescu opened this issue Aug 4, 2015 · 1 comment

Comments

@rpopescu
Copy link
Contributor

rpopescu commented Aug 4, 2015

Hi,

Pedantic warnings do not work on Clang (cmake 3.2.3, OSX 10.10.4, Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)).

I've made some changes to the main CMakeLists.txt to support that, and also fixed the shadowing warnings that come up with FMT_PEDANTIC set to ON.

I'm issuing a pull request now.
@vitaut
Copy link
Contributor

vitaut commented Aug 4, 2015

Good catch, thanks! Just one small comment in #191 .

@vitaut vitaut closed this as completed in 0affb23 Aug 4, 2015
vitaut added a commit that referenced this issue Aug 4, 2015
@vitaut
Merge pull request #191 from rpopescu/master
f9813c3 
fixed #190 Argument shadowing and Clang pedantic support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rpopescu @vitaut