Visual Studio 2017: warning C4456: declaration of 'result' hides prev… #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ious local declaration
|
Hi @chronoxor, thanks for the PR! Could you please review https://github.com/fmtlib/fmt/blob/ebec00138bd10e949ff34955bcb096387cd32acc/CONTRIBUTING.md, particularly the part about licensing, and let me know if you agree with it being applied both to this PR and your earlier contributions? |
|
Yes I agree. See no problems with the license. |
|
Great, thanks for confirmation. Also note that the future versions may be relicensed (probably as BSD + an optional clause to drop all requirements on binary redistribution): #1073 |
43 tasks
|
Does the PR require some other updates due to new licensing? |
Not really. Merged and thanks again for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ious local declaration