Improve behaviors when disabling exceptions #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # else | ||
| # define FMT_THROW(x) assert(false) | ||
| # define FMT_RETURN_AFTER_THROW(x) return x | ||
| # ifdef DEBUG |
There was a problem hiding this comment.
I think it should be #ifndef NDEBUG instead of #ifdef DEBUG.
|
Looks great, thanks. I have only two minor comments. |
|
Fixed, thanks |
vitaut
added a commit
that referenced
this pull request
Mar 15, 2015
Improve behaviors when disabling exceptions
|
Thanks! |
|
@CarterLi, could you please review the updated CONTIBUTING document, particularly the part about licensing, and let me know if you agree with it being applied to your contributions to {fmt}? The library is likely to be relicensed (#1073) so I'm collecting approval from all earlier contributors. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions which unconditionally throw exceptions should never return, with or without exception enabled
Tested compiler: AppleClang 6.1, brew g++-4.9 on OS X 10.10.2