improved use of find #1560
Merged
improved use of find #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*begin is supposed to be different from '{' when this find is used, so we can avoid checking it.
|
LGTM but please apply clang-format. Thanks! |
|
I'm sorry for the bad format, I changed it anyway. |
|
Thank you |
sthagen
added a commit
to sthagen/fmtlib-fmt
that referenced
this pull request
Feb 22, 2020
improved use of find (fmtlib#1560)
teajay-fr
pushed a commit
to teajay-fr/fmt
that referenced
this pull request
Mar 18, 2020
* improved use of find
*begin is supposed to be different from '{' when this find is used, so we can avoid checking it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*begin is supposed to be different from '{' when this find is used, so we can avoid checking it.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.