New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added #define WIN32_LEAN_AND_MEAN before including windows.h #1729

Merged

vitaut merged 2 commits into fmtlib:master from gabime:master

Jun 17, 2020

Contributor

gabime commented Jun 15, 2020

This prevents winsock2 redefinition warnings (e.g. see issue gabime/spdlog#1589) and minimizes the stuff that windows.h includes.

I also reversed the #ifdefcondition to avoid redefinition warnings if either NOMINMAX or WIN32_LEAN_AND_MEAN is already defined.

gabime added 2 commits

June 15, 2020 15:25


          Added WIN32_LEAN_AND_MEAN define before including windows.h

355e418


          indent

72edf35

vitaut merged commit 5aa5c98 into fmtlib:master

Contributor

vitaut commented Jun 17, 2020

Thanks!

gcerretani mentioned this pull request

NOMINMAX not handled properly #1855

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet