Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce compile time of variadic functions (2) #249

Merged
merged 2 commits into from
Dec 20, 2015

Conversation

dean0x7d
Copy link
Contributor

As discussed in #243 this PR changes the way the argument array is initialized.
Instead of recursion, the template parameter pack is expanded in the array initializer.

vitaut added a commit that referenced this pull request Dec 20, 2015
Reduce compile time of variadic functions (2)
@vitaut vitaut merged commit 3121ebd into fmtlib:master Dec 20, 2015
@vitaut
Copy link
Contributor

vitaut commented Dec 20, 2015

Merged, thanks!

@vitaut
Copy link
Contributor

vitaut commented Dec 20, 2015

I also merged https://github.com/dean0x7d/format-benchmark/tree/variadic-test into cppformat/format-benchmark repo. Hope you don't mind.

@dean0x7d
Copy link
Contributor Author

I also merged https://github.com/dean0x7d/format-benchmark/tree/variadic-test into cppformat/format-benchmark repo. Hope you don't mind.

Of course. I'm glad it was helpful.

@dean0x7d dean0x7d deleted the variadic-v3 branch February 11, 2016 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants