Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create doc/html directory #333

Closed
wants to merge 1 commit into from
Closed

Create doc/html directory #333

wants to merge 1 commit into from

Conversation

jeffs
Copy link

@jeffs jeffs commented May 24, 2016

The html directory must exist before the documentation can be built, or
else make reports the following error:

CMake Error at doc/cmake_install.cmake:31 (file):
  file INSTALL cannot find "/Users/jeff/pkg/fmtlib/fmt/doc/html".
Call Stack (most recent call first):
  cmake_install.cmake:33 (include)

make: *** [install] Error 1

This commit is just a work-around; I don't know enough CMake to update the build, but it probably should just create the html directory automatically if necessary.

The html directory must exist before the documentation can be built;
else, make reports the following error:

    CMake Error at doc/cmake_install.cmake:31 (file):
      file INSTALL cannot find "/Users/jeff/pkg/fmtlib/fmt/doc/html".
    Call Stack (most recent call first):
      cmake_install.cmake:33 (include)

    make: *** [install] Error 1
@@ -2,6 +2,7 @@ bin/
/_CPack_Packages
/doc/doxyxml
/doc/html

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just remove this instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that is a better approach. Why was the html directory ignored in the first place? It seemed like it might contain generated files (from *.rst) that should not be committed to version control.

@vitaut
Copy link
Contributor

vitaut commented May 24, 2016

Thanks for the PR, but the html directory should be created automatically when running make doc. What exactly are exact cmake and make commands that you run?

@jeffs
Copy link
Author

jeffs commented May 24, 2016

cmake -DCMAKE_INSTALL_PREFIX:PATH="$top/usr" .
make -j8 all install

This morning, the build work fines for me, though none of the code has
changed. Is it possible the "-j" flag to make just caused a race
condition?

On Tue, May 24, 2016 at 9:43 AM, Victor Zverovich notifications@github.com
wrote:

Thanks for the PR, but the html directory should be created automatically
when running make doc. What exactly are exact cmake and make commands
that you run?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#333 (comment)

[image: Orchard Platform] http://www.orchardplatform.com/

Jeffrey Schwab / Senior Software Engineer
(617) 407-2542 / jeff@orchardplatform.com

Orchard Platform
101 5th Avenue, 4th Floor, New York, NY 10003
http://www.orchardplatform.com

[image: Twitter] https://twitter.com/orchardplatform[image: Linkedin]
https://www.linkedin.com/company/orchard-app

Orchard Blog http://www.orchardplatform.com/blog/ | Marketplace Lending
Meetup http://www.meetup.com/Peer-to-Peer-Lending-P2P/

NOTICE TO RECIPIENTS: This communication is confidential and intended for
the use of the addressee only. If you are not an intended recipient of this
communication, please delete it immediately and notify the sender by return
email. Unauthorized reading, dissemination, distribution or copying of this
communication is prohibited. This communication does not constitute an
offer to sell or a solicitation of an indication of interest to purchase
any loan, security or any other financial product or instrument, nor is it
an offer to sell or a solicitation of an indication of interest to purchase
any products or services to any persons who are prohibited from receiving
such information under applicable law. The contents of this communication
may not be accurate or complete and are subject to change without notice.
As such, Orchard App, Inc. (including its subsidiaries and affiliates,
"Orchard") makes no representation regarding the accuracy or completeness
of the information contained herein. The intended recipient is advised to
consult its own professional advisors, including those specializing in
legal, tax and accounting matters. Orchard does not provide legal, tax or
accounting advice.

vitaut added a commit that referenced this pull request May 24, 2016
@vitaut
Copy link
Contributor

vitaut commented May 24, 2016

The problem is that the install target tries to install docs but they are only built with make doc. Should be fixed in dc1e36f. Thanks for catching this!

@vitaut vitaut closed this May 24, 2016
foonathan pushed a commit that referenced this pull request Oct 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants