Fix Windows compilation with -fno-exceptions #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, merged. ( @vitaut I'm just going to merge such trivial PRs when I see them, alright?) |
foonathan
pushed a commit
that referenced
this pull request
Oct 31, 2016
(cherry picked from commit 15d0f32)
|
Thanks @JanHellwig for another fix and @foonathan for merging. @foonathan, don't hesitate to merge PRs that you think don't need discussion. I fully trust your judgement. BTW I've added your name to maintainers in https://github.com/fmtlib/fmt#acknowledgments. Hope you don't mind =) and I really appreciate your work. |
vitaut
added a commit
that referenced
this pull request
Jan 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #402 but for Windows.