Fix Klockwork compilation warning

[chenhayat]

No description provided.

[vitaut]

Thanks for the PR, just one nitpick regarding code style.

[vitaut]

Please follow Google style guide: https://google.github.io/styleguide/cppguide.html

[foonathan]

@vitaut Could you perhaps add a .clang-format file? It would make contributing much easier.

Edit: For example this commit: d8867a2
I wrote the changes, compiled, ran tests, reformatted and accidentally deleted a '>'.
With clang-format autoformatting, this would not have happened.

[vitaut]

@foonathan What will be the benefit of having .clang-format in the project itself compared to say passing -style=google to clang-format?

[foonathan]

Oh, so you're using the google style without modification? Did not know that.

[vitaut]

Yes, with the exception of snake_case instead of CapitalizedWords for method names, but this doesn't affect formatting. I should probably document it somewhere.

[foonathan]

Yes, you should document it.

But running clang-format over the source files will also change some other stuff like the indentation of your #defines when in #ifdef, break lines differently, etc.

[vitaut]

@chenhayat Merged in 05ba3e7, thanks!

@foonathan I've documented the coding style in https://github.com/fmtlib/fmt/blob/master/CONTRIBUTING.rst. clang-format does mess up preprocessor indentation, so I am a bit reluctant of applying it globally. Hopefully they'll fix https://llvm.org/bugs/show_bug.cgi?id=17362 and until then I suggest limiting it to formatting patches.