Add join argument allowing formating list of values separated by a #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
string. Each value is formated according the format specifier.
|
Thanks for contributing. The PR looks good but could you follow the coding conventions described in https://github.com/fmtlib/fmt/blob/master/CONTRIBUTING.rst? |
|
Sorry. Hope it's ok now. |
vitaut
reviewed
Feb 6, 2017
fmt/format.h
Outdated
|
|
||
| template <typename Char, typename It> | ||
| struct ArgJoin | ||
| { |
There was a problem hiding this comment.
The brace belongs to the previous line. Otherwise looks good.
vitaut
requested changes
Feb 7, 2017
fmt/format.h
Outdated
| @@ -3865,6 +3865,72 @@ void BasicFormatter<Char, AF>::format(BasicCStringRef<Char> format_str) { | |||
| } | |||
| write(writer_, start, s); | |||
| } | |||
|
|
|||
|
|
|||
fmt/format.h
Outdated
| } | ||
| #endif | ||
|
|
||
|
|
fmt/format.h
Outdated
|
|
||
|
|
||
|
|
||
|
|
|
Merged, thanks! |
|
Thank you ! |
vitaut
added a commit
that referenced
this pull request
Jan 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
string. Each value is formated according the format specifier.