Don't include the world with WIN32_LEAN_AND_MEAN #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. |
bjoernthiel
pushed a commit
to AbberiorInstruments/fmt
that referenced
this pull request
May 11, 2017
foonathan
pushed a commit
that referenced
this pull request
Jun 8, 2017
(cherry picked from commit 4423490)
foonathan
pushed a commit
that referenced
this pull request
Jun 8, 2017
(cherry picked from commit 4423490)
vitaut
added a commit
that referenced
this pull request
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the size of what
windows.hwill include by using the defineWIN32_LEAN_AND_MEAN.In fact it also help to prevent bad order of inclusion because some header files in Windows need to be include in a good order and that can cause some problems when you use fmt without looking for what it is including.