Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unreachable code warning when signbit returns bool #640

Merged
merged 1 commit into from
Jan 21, 2018

Conversation

peterbell10
Copy link
Contributor

Fixes the following warning:

warning: will never be executed [-Wunreachable-code]
                    sizeof(signbit(x)) == sizeof(int))) {
                    ^~~~~~~~~~~~~~~~~~

@vitaut vitaut merged commit f78c3e4 into fmtlib:master Jan 21, 2018
@vitaut
Copy link
Contributor

vitaut commented Jan 21, 2018

Nice fix, thanks!

@peterbell10 peterbell10 deleted the unreachable_code branch January 21, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants