Fix sign conversion warnings #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
reviewed
Jun 24, 2018
include/fmt/core.h
Outdated
| @@ -749,7 +749,7 @@ class basic_parse_context : private ErrorHandler { | |||
|
|
|||
| // Advances the begin iterator to ``it``. | |||
| FMT_CONSTEXPR void advance_to(iterator it) { | |||
| format_str_.remove_prefix(it - begin()); | |||
| format_str_.remove_prefix(static_cast<std::size_t>(it - begin())); | |||
There was a problem hiding this comment.
Here and below I suggest using to_unsigned instead of a cast because it has an extra check (assert) that the value is actually nonzero.
|
Thanks for the PR, just one small comment inline.
-1 is used to denote "no precision" since 0 is a valid precision. |
foonathan
force-pushed
the
warning-fix
branch
2 times, most recently
from
244acd0
to
e6b91ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple static casts to fix -Wsign-conversion warnings.
There are a couple of weird things though, please take a look.
For example, why is precision an
intand not anunsigned?