Provide more overloads for the wide string flavour

[DanielaE]

Signed-off-by: Daniela Engert dani@ngrt.de

[vitaut]

Thanks for the PR, but we are trying to move from overloads to function templates in order to support more character types and reduce copy-paste. Please see

fmt/include/fmt/core.h

Line 1376 in 894b6fa

format(const String &format_str, const Args & ... args) {

for an example.

[DanielaE]

Great - I totally love to see this happening! I've already changed my code with respect to the format(rgb color, ...) family, now on to the vprint_rgb(rgb color, ...) family.

[DanielaE]

@vitaut Victor, do you have an idea why gcc 4.8 is failing to compile the templated printf(rgb color, ...) function, while all other compilers have no problems with it?

[vitaut]

gcc 4.8 is finicky. You need to explicitly construct basic_format_args to make it happy (see https://github.com/fmtlib/fmt/blob/master/include/fmt/core.h#L1447 for example).

[vitaut]

These should go to internal::data. Also you don't need the 000;000;000m part because you construct it in ansi_color_escape.

[vitaut]

nit: here and elsewhere const char [] -> const char *

[vitaut]

I suggest getting rid of the offset parameter and passing buffer pointer adjusted by offset instead.

[DanielaE]

@vitaut Thanks, Victor, for the tip regarding gcc 4.8 - it's happy now, too. I've incorporated the changes that you requested, as well.

[vitaut]

Thanks!