Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it java11 compatible #185

Merged
merged 2 commits into from
Feb 19, 2023
Merged

make it java11 compatible #185

merged 2 commits into from
Feb 19, 2023

Conversation

erwindon
Copy link
Contributor

@erwindon erwindon commented Feb 5, 2023

see #142

@erwindon erwindon marked this pull request as ready for review February 5, 2023 13:27
@erwindon erwindon marked this pull request as draft February 5, 2023 13:28
@erwindon
Copy link
Contributor Author

erwindon commented Feb 5, 2023

@petternordlander
the files in src/deb indicate the build of a Debian package, but it looks incomplete.
I just updated the Depends: clause in src/deb/control/control to include all currently known/suitable java-runtimes, i.e. 11 through 21
how can I test that?

@northlander
Copy link
Member

@erwindon thanks, will have a look this afternoon.

I must admit that I haven't tested the Debian part at all, a contribution by a Debian user. Would be nice to have it in some Debian/Ubuntu repo but I guess it's more effort than pay off. Perhaps we should just remove it.

@erwindon
Copy link
Contributor Author

erwindon commented Feb 6, 2023

That is very useful information on the context.
I have enough knowledge on Debian style packages to get this working. Already created a local Debian VM in VirtualBox for this.
I'll just add a few practical changes in this PR to be able to actually create a deb package, install it locally and run it.

@erwindon
Copy link
Contributor Author

erwindon commented Feb 6, 2023

no matter how popular the debian package of 'a' might become, the name 'a' as package name is never allowed. see https://www.debian.org/doc/debian-policy/ch-controlfields.html, where section 5.6.1 states that "[package names] must be at least two characters long and must start with an alphanumeric character."
I'll use 'fmtn-a' as debian package name (but feel free to suggest an even better one!)

@erwindon
Copy link
Contributor Author

erwindon commented Feb 7, 2023

I took one Debian specific file out of the first commit.

The second commit has all the Debian specific stuff in it:

  • added script to build the DEB package; and
  • fixed shell script (original name bin.sh, now a.sh) to start a; and
  • moved file control to proper location; filled the placeholders that it still had; and
  • set the package dependencies to java11+; the headless edition is sufficient.

verified Debian package by building+installing it --> Unix command a now shows the usage-text.

@erwindon erwindon marked this pull request as ready for review February 7, 2023 00:30
@erwindon
Copy link
Contributor Author

@northlander
(when) do you have time to review this?

@northlander northlander merged commit 00ec1a6 into fmtn:master Feb 19, 2023
@northlander
Copy link
Member

Awesome work @erwindon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants