Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Dockerfile #51

Merged
merged 1 commit into from
Dec 27, 2020
Merged

added Dockerfile #51

merged 1 commit into from
Dec 27, 2020

Conversation

erwindon
Copy link
Contributor

I hereby submit a plain Dockerfile.

hightlights:

  • a debian-linux image is used
  • the regular existing MVN build procedure is used
  • the default hostname has been replaced with {{host.docker.internal}} as the original hostname {{localhost}} points to a location within the docker container. since we did not put a message broker there that is useless. when a broker is running on the same machine, it works. otherwise the actual broker still needs to be specified as usual.

typical use:
{{docker run imagename a --get queue1}}
In docker one must provide the whole actual command with its parameters as arguments on startup (but most common is that the predefined command is already good, then nothing need to be given). Since {{a}} is a client program, it always needs extra parameters to tell it what to do.

Note that a {{Dockerfile}} does not assign a label, so label {{imagename}} will be different. A typical label in DockerHub is {{a:latest}}.

@northlander northlander merged commit 7df472b into fmtn:master Dec 27, 2020
@northlander
Copy link
Member

closes #42

@erwindon erwindon deleted the dockerfile branch December 27, 2020 21:37
@northlander
Copy link
Member

northlander commented Dec 27, 2020

Did some minor changes to the Docker setup. Such as a multi stage build with alpine/jdk8 as final runtime image and a .dockerignore file to reduce size.

@erwindon
Copy link
Contributor Author

erwindon commented Dec 27, 2020

@northlander
nice improvements!
from the initial issues description I could not derive your knowledge about Docker and assumed it was minimal. good to see that I was too pessimistic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants