Interpolate translation array #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the translation is an `Array`, the dynamic values were not interpolated.
|
Can you add related test to prove your change is working? |
|
Done ! Let me know if something more is needed. |
PikachuEXE
reviewed
Jun 6, 2018
app/assets/javascripts/i18n.js
Outdated
| @@ -598,6 +598,8 @@ | |||
|
|
|||
| if (typeof(translation) === "string") { | |||
| translation = this.interpolate(translation, options); | |||
| } else if (isArray(translation)) { | |||
| translation = translation.map((t) => this.interpolate(t, options)); | |||
There was a problem hiding this comment.
- This
() => somethingsyntax is not ES5 syntax, please update it - Please add shim for
Array#maptoapp/assets/javascripts/i18n/shims.js
added 2 commits
June 6, 2018 10:24
|
Done. |
|
Thanks! |
|
Released as gem and npm package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the translation is an
Array, the dynamic values were not interpolated.