Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cs.json #154

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Create cs.json #154

wants to merge 7 commits into from

Conversation

Atrexikk
Copy link

Fnbr.co translation to Czech Language.

Fnbr.co translation to Czech Language.
Copy link
Collaborator

@Krymonota Krymonota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for your contribution!

I've reviewed your pull request and found some things that you need to correct. There are comments and suggestions for some lines. Also, please make sure you remove leading and trailing spaces in the strings as there are many of them and they don't belong there.

Once you've made your adjustments, I'd happy to take another look at your pull request. Please also let me know your Discord username and tag (e.g. JohnDoe#1234) so that you can be added to the list of translators, receive your Discord role and an ad-free website experience 🙂

cs.json Show resolved Hide resolved
cs.json Outdated Show resolved Hide resolved
cs.json Outdated Show resolved Hide resolved
cs.json Outdated Show resolved Hide resolved
"title-featured" : " Doporučené Itemy",
"title-daily" : " Denní Itemy",
"error" : " Obchod není k dispozici, zkuste to prosím za chvíli znovu.",
"line1" : " Aktuální rotace item shopu s itemy pro hru Fortnite: Battle Royale - aktualizace bývá denně zde: [00:00 UTC](https://time.is/UTC|tooltip=Current time in UTC|newtab=true).",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current time in UTC needs to be translated.

cs.json Outdated Show resolved Hide resolved
cs.json Outdated Show resolved Hide resolved
cs.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@Krymonota Krymonota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found two more issues that result in invalid JSON. The suggestions are going to fix it when being applied.

cs.json Outdated Show resolved Hide resolved
cs.json Outdated Show resolved Hide resolved
fixed translation errors
@Atrexikk
Copy link
Author

Hello,
my discord: ATREX#6223

Copy link
Collaborator

@Krymonota Krymonota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to fix some of the issues. I also pushed some commits to fix some of the issues I mentioned in my first review. However, there are still a few things you need to fix:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants