VCR integration #320
Merged
VCR integration #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial checkin payment spec first cassettes
Move payment received functionality to model added specs
kigster
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Awesome work man! Tests now pass in 6 seconds!!! Whoohoo!
Can you add to README instructions on how to regenerate cassettes if any of the APIs change? Or how to turn off using cassettes and turn on cassette generation?
I left a couple of tiny questions but this is nearly ready to go.
| @@ -141,6 +141,7 @@ def retrieve_payment_intent | |||
| end | |||
|
|
|||
| Rails.logger.debug { "retrieve_payment_intent payment => #{inspect}}" } | |||
| self.payment_intent | |||
There was a problem hiding this comment.
Remove self since it's a reader
app/models/payment.rb
Outdated
| # mark payment received and ticket request completed | ||
| # Send off PaymentMailer for payment received | ||
| def request_completed | ||
| mark_received |
There was a problem hiding this comment.
Do we want to wrap these two in a transaction?
There was a problem hiding this comment.
I'll move the transaction from the controller.
kigster
reviewed
Oct 5, 2024
kigster
reviewed
Oct 5, 2024
| ticket_request.mark_complete | ||
| Payment.transaction do | ||
| # set payment and ticket request status | ||
| mark_received |
kigster
approved these changes
Oct 5, 2024
kigster
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checkin
payment spec first cassettes