Added the pinged IP address to alfred notification output #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed "a" to "at" in the notification output text.
fniephaus
requested changes
Sep 13, 2019
Removing 'command' from ping for IP address in notification as requested by @fniephaus. It was initially added because in rare cases, some shell integrations (i.e ZSH plugins) override the default command for ping with a function. In my case, ping is actually a function that accepts and parses URLs in addition to domains (e.g. ping https://github.com). However, the fallacy would actually be on the plugin in this case, and it is unlikely that this would be loaded into the bash shell within Alfred anyways, so we're removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.