Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis CI config #53

Merged
merged 4 commits into from
May 2, 2021
Merged

Update Travis CI config #53

merged 4 commits into from
May 2, 2021

Conversation

fnogatz
Copy link
Owner

@fnogatz fnogatz commented May 1, 2021

  • Remove unnecessary environment variable GITHUB_OAUTH_TOKEN (former API limit has been removed in 2016)
  • Remove manual doctrine/instantiator downgrade
  • We support only PHP 7.3 and 7.4 (former versions reached EOL)
  • We support only Magento 2 versions starting from v2.3.5
  • Add declaration of return value in setUp(): void in *Test.php as required by PHPUnit

Pull request resolves #52.

- Remove unnecessary environment variable GITHUB_OAUTH_TOKEN (former API limit has been [removed](composer/composer#4884 (comment)) in 2016)
- Remove manual doctrine/instantiator downgrade
- We support only PHP 7.3 and 7.4 as well as M2 starting from v2.3.3 (former versions reached EOL)
@fnogatz fnogatz self-assigned this May 1, 2021
fnogatz added 3 commits May 2, 2021 09:45
setUp() must be compatible with PHPUnit\Framework\TestCase::setUp() – add missing declaration of "void" as return value
Magento version prior to v2.3.5 depend on xdebug<3, so these tests fail with a "Call to undefined function xdebug_disable()" error. We simply stick to the latest two versions of Magento v2.3.x.
@fnogatz fnogatz marked this pull request as ready for review May 2, 2021 08:34
@fnogatz fnogatz merged commit bc70f62 into main May 2, 2021
@fnogatz fnogatz deleted the fix-travis-issue-52 branch May 2, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Travis
1 participant